Jefffrey commented on code in PR #11533:
URL: https://github.com/apache/arrow-rs/pull/11533#discussion_r4255755821
##########
arrow-schema/src/fields.rs:
##########
@@ -309,7 +309,12 @@ impl<'a> IntoIterator for &'a Fields {
}
}
-/// A cheaply cloneable, owned collection of [`FieldRef`] and their
corresponding type ids
+/// A cheaply cloneable, owned collection of [`FieldRef`] and their
corresponding
+/// type ids.
+///
+/// Invariants:
+/// - All type ids are unique
+/// - All type ids are non-negative
#[derive(Clone, Eq, PartialEq, Ord, PartialOrd, Hash)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
Review Comment:
identified by codex review, but having these serde derives still allows a
loophole; i dont know the impact of removing them (if even possible)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
