Rich-T-kid commented on code in PR #11407:
URL: https://github.com/apache/arrow-rs/pull/11407#discussion_r4274552730
##########
arrow-cmp/src/lib.rs:
##########
@@ -798,6 +904,83 @@ mod tests {
assert_eq!(Ordering::Greater, cmp(1, 3));
}
+ #[test]
+ fn dict_fixed_size_binary_fast_path_derefs_values_both_directions() {
+ let shared_keys = || Int32Array::from(vec![0_i32, 1]);
+ let left_values =
+ FixedSizeBinaryArray::try_from_iter([b"zz".as_ref(),
b"aa".as_ref()].into_iter())
+ .unwrap();
+ let right_values =
+ FixedSizeBinaryArray::try_from_iter([b"aa".as_ref(),
b"zz".as_ref()].into_iter())
+ .unwrap();
+ let left = DictionaryArray::<Int32Type>::new(shared_keys(),
Arc::new(left_values));
+ let right = DictionaryArray::<Int32Type>::new(shared_keys(),
Arc::new(right_values));
+
+ let ascending = make_comparator(&left, &right,
SortOptions::default()).unwrap();
+ assert_eq!(ascending(0, 0), Ordering::Greater);
+ assert_eq!(ascending(1, 1), Ordering::Less);
+
+ let descending = make_comparator(
+ &left,
+ &right,
+ SortOptions {
+ descending: true,
+ nulls_first: true,
+ },
+ )
+ .unwrap();
+ assert_eq!(descending(0, 0), Ordering::Less);
+ assert_eq!(descending(1, 1), Ordering::Greater);
+ }
+
+ #[test]
+ fn dict_bytes_fast_path_derefs_values_both_directions() {
+ let shared_keys = || Int32Array::from(vec![0_i32, 1]);
+ let left = DictionaryArray::<Int32Type>::new(
+ shared_keys(),
+ Arc::new(StringArray::from(vec!["z", "a"])),
+ );
+ let right = DictionaryArray::<Int32Type>::new(
+ shared_keys(),
+ Arc::new(StringArray::from(vec!["a", "z"])),
+ );
+
+ let ascending = make_comparator(&left, &right,
SortOptions::default()).unwrap();
+ assert_eq!(ascending(0, 0), Ordering::Greater);
+ assert_eq!(ascending(1, 1), Ordering::Less);
+
+ let descending = make_comparator(
+ &left,
+ &right,
+ SortOptions {
+ descending: true,
+ nulls_first: true,
+ },
+ )
+ .unwrap();
+ assert_eq!(descending(0, 0), Ordering::Less);
+ assert_eq!(descending(1, 1), Ordering::Greater);
+ }
+
+ #[test]
+ fn dict_bytes_fallback_handles_key_and_value_nulls() {
+ // Left carries a logical null via a null KEY at row 1.
+ let left_keys = Int32Array::from(vec![Some(0_i32), None, Some(1)]);
+ let left_values = Arc::new(StringArray::from(vec!["apple", "banana"]));
+ let left = DictionaryArray::<Int32Type>::new(left_keys, left_values);
+
+ // Right carries a logical null via a null VALUE referenced at row 1.
+ let right_keys = Int32Array::from(vec![Some(0_i32), Some(1), Some(0)]);
+ let right_values = Arc::new(StringArray::from(vec![Some("apple"),
None]));
+ let right = DictionaryArray::<Int32Type>::new(right_keys,
right_values);
+
+ let cmp = make_comparator(&left, &right,
SortOptions::default()).unwrap();
+ assert_eq!(cmp(0, 0), Ordering::Equal); // apple vs apple
+ assert_eq!(cmp(1, 0), Ordering::Less); // null-key < apple
(nulls_first)
+ assert_eq!(cmp(0, 1), Ordering::Greater); // apple > null-value
(nulls_first)
+ assert_eq!(cmp(1, 1), Ordering::Equal); // null-key vs null-value
+ }
Review Comment:
I added test that cover all off these cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
