Jefffrey opened a new issue, #11575:
URL: https://github.com/apache/arrow-rs/issues/11575

   ### Is your feature request related to a problem or challenge?
   
   `UnionFields::try_merge` has an outstanding TODO item that it may introduce 
duplicates:
   
   
https://github.com/apache/arrow-rs/blob/125d3ccea6f5f4a100868093e82b319640dc3906/arrow-schema/src/fields.rs#L594-L601
   
   Recently as part of #11533 I did some changes to ensure it goes through 
`try_new` to check for this:
   
   
https://github.com/apache/arrow-rs/blob/125d3ccea6f5f4a100868093e82b319640dc3906/arrow-schema/src/fields.rs#L624-L628
   
   ### Describe the solution you'd like
   
   See if we can refactor `try_merge` to handle duplicates directly instead of 
relying on a second pass through `try_new`. If this doesn't result in cleaner 
code, than just remove the TODO items after verifying they are no longer needed 
(i.e. `try_merge` can't introduce duplicates without erroring
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to