edponce commented on pull request #10395: URL: https://github.com/apache/arrow/pull/10395#issuecomment-849481217
The `sign` function is an arithmetic function, therefore, I added its option `allow_signed_zero` to the [`ArithmeticOptions`](https://github.com/apache/arrow/pull/10395/files#diff-6bc7ecec6a4f7bcefc2511cde3bd809340ad0d94bb8f7cc5f4994063c798f2faR41) class. Is this valid? given that `sign` does not overflows so it will not make use of the `check_overflow` and currently, other compute functions do not use the `allow_signed_zero` option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
