CurtHagenlocher commented on code in PR #4919:
URL: https://github.com/apache/arrow-adbc/pull/4919#discussion_r4307848586
##########
csharp/src/Apache.Arrow.Adbc/Extensions/IArrowArrayExtensions.cs:
##########
@@ -156,16 +157,31 @@ public static class IArrowArrayExtensions
}
case ArrowTypeId.Binary:
return ((BinaryArray)arrowArray).GetBytes(index).ToArray();
+ case ArrowTypeId.FixedSizedBinary:
+ return
((FixedSizeBinaryArray)arrowArray).GetBytes(index).ToArray();
case ArrowTypeId.List:
- return ((ListArray)arrowArray).GetSlicedValues(index);
+ return GetListValues((ListArray)arrowArray, index);
case ArrowTypeId.Struct:
StructArray structArray = (StructArray)arrowArray;
return resultType == StructResultType.JsonString ?
SerializeToJson(structArray, index) : ParseStructArray(structArray, index);
+ case ArrowTypeId.Extension:
+ switch (arrowArray)
+ {
+ case GuidArray guidArray:
+ return guidArray.GetGuid(index);
+ case Bool8Array bool8Array:
+ return bool8Array.GetValue(index);
+ case TimestampWithOffsetArray timestampWithOffsetArray:
+ return timestampWithOffsetArray.GetValue(index);
+ case ExtensionArray extensionArray:
+ // Unrecognized extension types are surfaced as
their storage values.
+ return ValueAt(extensionArray.Storage, index,
resultType);
Review Comment:
Follow-up in ac532fed4: the `Apache.Arrow.Operations` dependency is gone
again. Unshredded variants are decoded with `Apache.Arrow` alone and formatted
with the same JSON writer as structs, and nested variants still convert as
described above. Shredded variants are now opt-in: an application references
`Apache.Arrow.Operations` and sets `ShreddedVariants.Reader = (array, index) =>
array.GetLogicalVariantValue(index)`. Without that, reading a shredded variant
throws a `NotSupportedException` that explains how to enable it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
