bharadwaj-pendyala commented on PR #11257: URL: https://github.com/apache/arrow-rs/pull/11257#issuecomment-6258798230
Reworked the `filter_nulls` tests in 27f8312. `nullable_values` now builds 200 rows from a vec and nulls out `NULL_ROWS = [0, 64, 199]` instead of deriving the null rows from a modulo. That covers three full words plus an 8-bit partial one, with each null row in a different word. The threshold comment now names `FILTER_SLICES_SELECTIVITY_THRESHOLD`, the remaining chain only builds the same mask at offset 1 and says so in a comment, and `test_filter_nulls_too_large` builds its nulls and mask from vecs. 287ff06 moves the `selects_null` call below the `None` and `All` arms, so those two strategies skip the scan. The length assert stays in `filter_nulls` with its old message. The description's note about new `nulls.len() >= len` panic text no longer applies. `cargo test -p arrow-select` passed all 456 tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
