raulcd opened a new pull request, #54573: URL: https://github.com/apache/arrow/pull/54573
### Rationale for this change For older versions of CMake the variable `arrow_SOURCE_DIR` is overriden by FetchContent's one because `project(arrow)` sets it as a cache variable while FetchContent sets a normal variable with precedence. Arrow can't find `thirdparty/versions.txt` because it is pointing to the tarball root instead of the cpp subfolder. See policy https://cmake.org/cmake/help/latest/policy/CMP0180.html This has been tested and found at Iceberg-cpp here: - https://github.com/apache/iceberg-cpp/pull/1029 ### What changes are included in this PR? Use `ARROW_SOURCE_DIR` instead of `arrow_SOURCE_DIR` so FetchContent's `arrow_SOURCE_DIR` does not have precedence. ### Are these changes tested? Yes locally on the iceberg PR on Ubuntu 24.04. ### Are there any user-facing changes? No ### Was AI used for this PR? In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR. **PR code and description written by:** - [x] Human - [ ] AI I did use AI to initially find the root cause. **Reviewed before submission by:** - [x] Human - [ ] AI - [ ] Not reviewed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
