pearu commented on PR #50146: URL: https://github.com/apache/arrow/pull/50146#issuecomment-6275629732
@kou, @ianmcook: the split is done. This PR stays open as a reference until the following PRs have landed: Fixes to the strptime timestamp parser, independent of each other: - #54656 (GH-54641): support `%a`, `%b`, `%p` and other locale directives on Windows - #54657 (GH-54643): reject impossible dates and a zero day - #54658 (GH-54646): reject years out of range - #54659 (GH-54647): reject leap seconds The feature, split into dates and times: - #54661 (GH-54650): `timestamp_parsers` as a fallback for CSV date columns - #54662 (GH-54651): the same for CSV time columns Landing order: #54656, #54657, #54658 and #54659 can land in any order; #54657 and #54659 touch the same test lines, so whichever lands second needs a rebase. #54661 includes the commits of #54656, #54657 and #54659 and must land after them. #54662 builds on #54661 and must land after it. @ianmcook, could you review and approve these as you did here? @kou, could you review them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
