Rich-T-kid commented on code in PR #10737:
URL: https://github.com/apache/arrow-rs/pull/10737#discussion_r4328138231
##########
arrow-schema/src/error.rs:
##########
@@ -21,9 +21,13 @@ use std::io::Write;
use std::error::Error;
+use arrow_buffer::BufferError;
Review Comment:
Im not sure if we want to make `arrow-schema` be dependent on `arrow-buffer`
##########
arrow-buffer/src/error.rs:
##########
@@ -17,6 +17,87 @@
//! Errors returned by `arrow-buffer`.
+/// An error returned by a fallible buffer operation.
+///
+/// This error aggregates the specific errors that can occur in `arrow-buffer`.
+#[derive(Debug)]
+pub enum BufferError {
+ /// An arithmetic overflow.
+ Overflow(OverflowError),
+ /// An offset or range outside the buffer bounds.
+ OutOfBounds(OutOfBoundsError),
+ /// A buffer with insufficient alignment for a scalar type.
+ Misaligned(AlignmentError),
+}
Review Comment:
should we also mesh this together with
https://docs.rs/arrow/latest/arrow/buffer/enum.MutableBufferError.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
