AntoinePrv commented on code in PR #50629:
URL: https://github.com/apache/arrow/pull/50629#discussion_r4334825996
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -724,358 +690,816 @@ class SkippableTypedDecoder {
}
};
-// ----------------------------------------------------------------------
-// Impl base class for TypedColumnReader and RecordReader
+/*********************
+ * ValueSinkCursor *
+ *********************/
-template <typename DType>
-class ColumnReaderImplBase {
+inline int64_t compute_capacity_pow2(int64_t capacity, int64_t size, int64_t
extra_size) {
Review Comment:
Sorry, I do get confised when function should be snake_case and when they
should be PascalCase.
✔️ Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
