Rich-T-kid commented on code in PR #11714:
URL: https://github.com/apache/arrow-rs/pull/11714#discussion_r4338979634
##########
arrow/benches/interleave_kernels.rs:
##########
@@ -222,5 +222,86 @@ fn add_benchmark(c: &mut Criterion) {
}
}
-criterion_group!(benches, add_benchmark);
+// Alternating sources prevent parent-row coalescing, while each selected list
+// still supplies a contiguous child range. Include singleton and skewed lists,
+// plus primitive children as a control for the existing bulk-copy path.
+fn bench_list_ranges(c: &mut Criterion) {
+ const ROWS: usize = 4096;
+ const SOURCES: usize = 6;
+ let indices: Vec<_> = (0..ROWS).map(|i| (i % SOURCES, i /
SOURCES)).collect();
+ for (shape, lengths) in [
+ ("1", &[1][..]),
+ ("15", &[15][..]),
+ ("90", &[90][..]),
+ ("mixed", &[0, 1, 15, 90, 0, 1, 1, 256][..]),
+ ] {
Review Comment:
do wee need all of these shapes? this pr will add 16 benchmarks. Im not sure
having the 90 benchmark case will be a realistic use case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
