lidavidm commented on code in PR #4939:
URL: https://github.com/apache/arrow-adbc/pull/4939#discussion_r4344823374
##########
r/adbcdrivermanager/tests/testthat/test-error.R:
##########
@@ -41,6 +41,33 @@ test_that("error allocator works", {
expect_identical(err$details, setNames(list(), character()))
})
+test_that("stop_for_error() does not truncate long error messages", {
+ # Long messages (e.g., the list of paths searched for a driver manifest)
+ # should not be cut off at the default warning.length of 1000 characters
+ old_options <- options(warning.length = 1000L)
+ on.exit(options(old_options))
+
+ warning_length_while_signalled <- NULL
+ had_error <- FALSE
+ tryCatch(
+ withCallingHandlers(
+ adbc_driver(paste0("not_a_driver_", strrep("x", 1000))),
Review Comment:
Hmm, sounds like the driver manager should be catching this (we can handle
that separately)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
