dmitry-chirkov-dremio commented on code in PR #54684:
URL: https://github.com/apache/arrow/pull/54684#discussion_r4345993984
##########
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc:
##########
@@ -1262,16 +1262,19 @@ struct Strftime {
// Convert string representations of timestamps in arbitrary format to
timestamps
const std::string GetZone(const std::string& format) {
- // Check for use of %z or %Z
+ // Check for use of %z or %Ez
Review Comment:
`%Ez` is now recognized here and in `StrptimeTimestampParser`, but
`Strftime::Make` still checks only `%z` and `%Z` when the input has no
timezone. This means `%Ez` is treated as UTC while `%z` is rejected. Please use
the same format check in both paths and add tests for `%Ez` with and without a
timezone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
