dmitry-chirkov-dremio commented on code in PR #51384:
URL: https://github.com/apache/arrow/pull/51384#discussion_r4348110017


##########
cpp/src/arrow/util/CMakeLists.txt:
##########
@@ -50,7 +50,6 @@ add_arrow_test(utility-test
                base64_test.cc
                byte_size_test.cc
                byte_stream_split_test.cc
-               cache_test.cc

Review Comment:
   The CMake entries are removed, but the Meson build still references both 
deleted files. I reproduced this on commit `19a3c88b`.
   
   With tests enabled:
   
   ```bash
   CC=/usr/bin/clang CXX=/usr/bin/clang++ CCACHE_DISABLE=1 \
   uvx --from meson meson setup build-tests cpp \
     -Dauto_features=disabled \
     -Dtests=enabled \
     -Dbenchmarks=enabled \
     -Dipc=disabled \
     --wrap-mode=forcefallback
   ```
   
   Meson fails with:
   
   ```text
   cpp/src/arrow/util/meson.build:241:6:
   ERROR: File cache_test.cc does not exist.
   ```
   
   With tests disabled and benchmarks enabled, it also fails with:
   
   ```text
   cpp/src/arrow/util/meson.build:311:10:
   ERROR: File cache_benchmark.cc does not exist.
   ```
   
   Please remove `cache_test.cc` and the `cache` benchmark from 
`cpp/src/arrow/util/meson.build`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to