Jefffrey commented on code in PR #11815:
URL: https://github.com/apache/arrow-rs/pull/11815#discussion_r4348242133
##########
arrow-data/src/transform/run.rs:
##########
@@ -644,4 +648,63 @@ mod tests {
// This should cause overflow: (i32::MAX - 50) + 100 > i32::MAX
mutable.extend(0, 0, 100);
}
+
+ #[test]
+ #[should_panic(expected = "run end overflow")]
+ fn test_extend_nulls_overflow() {
+ let values = create_int32_array_data(vec![10]);
+ let array = create_run_array_data_int16(vec![100], values);
+
+ let mut mutable = MutableArrayData::new(vec![&array], true, 10);
+ mutable.extend_nulls(i16::MAX as usize + 1);
+ }
+
+ #[test]
+ fn test_extend_accounts_for_offset() {
+ let dt = DataType::RunEndEncoded(
+ Arc::new(Field::new("run_ends", DataType::Int32, false)),
+ Arc::new(Field::new("values", DataType::Float32, true)),
+ );
+
+ let runs = ArrayData::builder(DataType::Int32)
+ .len(2)
+ .offset(2)
+ .add_buffer(vec![-10_i32, -20, 1_i32, 4, 0, 100].into())
+ .build()
+ .unwrap();
+ let values = ArrayData::builder(DataType::Float32)
+ .len(2)
+ .add_buffer(vec![1.5, 2.5].into())
+ .build()
+ .unwrap();
+
+ let source_data = ArrayDataBuilder::new(dt.clone())
+ .len(3)
+ .child_data(vec![runs, values])
+ .build()
+ .unwrap();
+
+ let mut mutable = MutableArrayData::new(vec![&source_data], true, 10);
+ mutable.extend(0, 0, 1);
+ let data = mutable.freeze();
+
+ let expected = {
Review Comment:
- since we're not backporting #11536 (see
https://github.com/apache/arrow-rs/issues/11666#issuecomment-6339967324) i
adjusted the test so equality can be done without needing logical comparison
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
