alamb commented on pull request #403: URL: https://github.com/apache/arrow-datafusion/pull/403#issuecomment-850334886
> I guess it's not arbitrary but rather just take the ordering as is. When #425 is merged I'll add one test case to compare with psql so the behavior is consistent. Sounds good -- makes sense. As @Dandandan says what this means to me is that there is no well defined "correct result" for the query (and thus the test is ensuring the code doesn't crash, but doesn't really ensure it is getting the correct values) > Of course when ordering clause is implemented then the behavior can also be tested in the same way, along with some unit test. 👍 > I plan to implement ordering after this and the lead/lag PR are merged because it requires some structural changes to the planner. I think that makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
