zeroshade commented on PR #1407: URL: https://github.com/apache/arrow-go/pull/1407#issuecomment-6370923426
Thanks for picking this up, @nirajan1111, and for the clear write-up and test. We're going to close this in favour of #1406, which was opened earlier the same day with an equivalent fix for #69: the same `(Decryptor, error)` signatures and the same error in place of the panic, propagated through `NewColumnChunkMetaData` and `GetColumnPageReader`. Your `TestDecryptHiddenColumn` and #1406's test both catch the panic, so nothing is lost. For next time: commenting "take" on the issue *before* starting work helps avoid two people fixing the same thing. Thanks again, and we'd be glad to see more contributions from you. --- > *This comment was drafted by an AI-assisted tool and > confirmed by an Apache Arrow maintainer. If something feels > off, please reply on the PR and a maintainer will follow up.* > > *More on how Apache Arrow handles maintainer review:* > [CONTRIBUTING.md](https://github.com/apache/arrow-go/blob/main/CONTRIBUTING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
