jonkeane commented on a change in pull request #10334:
URL: https://github.com/apache/arrow/pull/10334#discussion_r641512824
##########
File path: r/tests/testthat/test-dplyr-string-functions.R
##########
@@ -493,3 +493,81 @@ test_that("edge cases in string detection and
replacement", {
tibble(x = c("ABC"))
)
})
+
+test_that("strptime", {
+
+ t_string <- tibble(x = c("2018-10-07 19:04:05", NA))
+ t_stamp <- tibble(x = c(lubridate::ymd_hms("2018-10-07 19:04:05"), NA))
+ t_stampPDT <- tibble(x = c(lubridate::ymd_hms("2018-10-07 19:04:05", tz =
"PDT"), NA))
Review comment:
I think that that's what we want actually.
In many other cases where something isn't (yet) supported in Arrow we
automatically pull the data into R with a warning (in some circumstances like
this). You might have found this already, but the pattern you propose for the
test in your comment matches what we do elsewhere
https://github.com/apache/arrow/blob/master/r/tests/testthat/test-dplyr-string-functions.R#L360-L369
which is good (comments about that test also have a bit more explanation about
what's going on when the data warnings+is pulled in)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
