kou commented on code in PR #54927:
URL: https://github.com/apache/arrow/pull/54927#discussion_r4365089669
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3848,6 +3874,19 @@ function(build_google_cloud_cpp_storage)
PUBLIC $<BUILD_INTERFACE:${_otel_api_includes}>)
endif()
+ # google-cloud-cpp headers use deprecated Abseil APIs such as
+ # absl::visit(). They are fixed in google-cloud-cpp 3.9.0 or later
+ # but google-cloud-cpp 3.9.0 or later requires libcurl 8.7.1 or
+ # later. We can't require it because some supported platforms such as
+ # Ubuntu 24.04 ship older libcurl.
+ #
+ # TODO: Remove this workaround once we upgrade to google-cloud-cpp
+ # 3.9.0 or later.
Review Comment:
Hmm. I think that we don't need them for now. If we update a bundled
dependency, we must check existing `build_XXX()` and remove needless
workarounds. So TODO comments in this file is enough. Let's create an issue
when we have any upgrade request. It tracks upgrade progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
