Jefffrey commented on code in PR #11764:
URL: https://github.com/apache/arrow-rs/pull/11764#discussion_r4366521083
##########
arrow/tests/run_end_encoded.rs:
##########
Review Comment:
these should be unit tests in their respective files
##########
arrow-row/src/run.rs:
##########
@@ -90,12 +91,6 @@ pub unsafe fn decode<R: RunEndIndexType>(
field: &SortField,
validate_utf8: bool,
) -> Result<RunArray<R>, ArrowError> {
- if rows.is_empty() {
Review Comment:
i feel its less confusing to keep this, and perhaps use something like
[`new_empty_array`](https://docs.rs/arrow/latest/arrow/array/fn.new_empty_array.html)
here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
