ianmcook commented on a change in pull request #10390:
URL: https://github.com/apache/arrow/pull/10390#discussion_r641613706
##########
File path: docs/source/cpp/compute.rst
##########
@@ -310,6 +310,20 @@ output element is null.
| less, less_equal | |
| |
+--------------------------+------------+---------------------------------------------+---------------------+
+These functions take any number of inputs of numeric type (in which case they
+will be cast to the :ref:`common numeric type <common-numeric-type>` before
+comparison) or of temporal types. If any input is dictionary encoded it will be
+expanded for the purposes of comparison.
+
++--------------------------+------------+---------------------------------------------+---------------------+---------------------------------------+-------+
+| Function names | Arity | Input types
| Output type | Options class | Notes |
++==========================+============+=============================================+=====================+=======================================+=======+
+| maximum, minimum | Varargs | Numeric and Temporal
| Numeric or Temporal | :struct:`ElementWiseAggregateOptions` | \(1) |
Review comment:
I agree that using `least` and `greatest` would not fully resolve the
ambiguity (except to users familiar with SQL) but the use of these synonyms
would at least signal that these are something different from `min` and `max`.
I think `element_wise_min` and ` element_wise_max` are fine and do a better job
of disambiguating as long as we're OK with their length.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
