advitrocks9 commented on PR #52469: URL: https://github.com/apache/arrow/pull/52469#issuecomment-6385024533
@pitrou Thanks! I've made the changes. I'd moved the range check first so out of range values wouldn't be converted, but the cast still converts them in null slots and when truncation isn't allowed. So I moved it back after the conversion and removed `out_at`. I added the cases you listed. 9223372036854775807 and 9223372036854775807.5 round to 2^63 as float or double, so they fail, and -9223372036854775808.5 rounds to -2^63 and casts to INT64_MIN. @dmitry-chirkov-dremio That means I've undone the reordering you asked for. I measured the 1.6-2x against main's round trip, in a standalone loop rather than the kernel. I've also fixed the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
