nirajan1111 opened a new pull request, #1420:
URL: https://github.com/apache/arrow-go/pull/1420

   ### Rationale for this change
   
   The FlightSQL `database/sql` driver only accepts `flightsql://` DSNs. 
pyarrow, C++, Java and ADBC use `grpc+tcp://`, `grpc+tls://` and 
`grpc+unix://`. Closes #57.
   
   ### What changes are included in this PR?
   
   - `grpc+tcp://host:port` behaves like `flightsql://`.
   - `grpc+tls://host:port` enables TLS by default; `tls=<name>` still selects 
a registered config, and `tls=false`/`disabled` is an error.
   - `grpc+unix:///path` connects to a Unix domain socket (address 
`unix:///path`).
   - `DSN()` emits `grpc+unix://` for socket addresses; other output is 
unchanged.
   - README documents the schemes.
   
   ### Are these changes tested?
   
   Yes. New table cases in `config_test.go` for parsing, errors and `DSN()`, 
and `TestUnixSocketConnection` runs a query against the SQLite example server 
over a Unix socket. All fail on main with `invalid scheme`.
   
   - `go test ./arrow/flight/flightsql/driver/ ./arrow/flight/flightsql/ 
-count=1 -race`
   - `golangci-lint run` in `arrow/`: 0 issues
   
   ### Are there any user-facing changes?
   
   Yes, three new accepted DSN schemes. Existing `flightsql://` DSNs behave the 
same.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to