Rich-T-kid commented on code in PR #11899:
URL: https://github.com/apache/arrow-rs/pull/11899#discussion_r4372509932
##########
arrow-array/src/temporal_conversions.rs:
##########
@@ -434,4 +434,58 @@ mod tests {
assert_eq!(sec, -124);
assert_eq!(nano_sec, 999_999_999);
}
+
+ #[test]
+ fn test_time_conversions_out_of_bounds_no_wrapping() {
+ use crate::temporal_conversions::{
+ time32ms_to_time, time32s_to_time, time64ns_to_time,
time64us_to_time,
+ };
+ use chrono::NaiveTime;
Review Comment:
can you place these imports at the test module level
##########
arrow-array/src/temporal_conversions.rs:
##########
@@ -434,4 +434,58 @@ mod tests {
assert_eq!(sec, -124);
assert_eq!(nano_sec, 999_999_999);
}
+
+ #[test]
+ fn test_time_conversions_out_of_bounds_no_wrapping() {
Review Comment:
the change here is simpler than the test would suggest. can we make this
test function simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
