zeroshade opened a new pull request, #1422:
URL: https://github.com/apache/arrow-go/pull/1422

   ### Rationale for this change
   
   The macOS ARM64 Test jobs are running into their `timeout-minutes`. In the 
last 40 Test runs, successful `ARM64 macOS 14 Go 1.26` jobs took 14–17 minutes 
against a 20-minute limit, and two jobs were cancelled at the limit today 
(#1414's `ARM64 macOS 14 Go 1.26`, #1421's `ARM64 macOS 14 Go 1.26 - CGO`), 
both during the last command of `ci/scripts/test.sh`: `go test -race -tags 
assert,noasm …/parquet/file`. All tests that had run passed.
   
   On macOS, `parquet/file` runs in its own invocation, once per tag set 
(`assert`, then `assert,noasm`); under `-race` that takes about 90 seconds or 
more each time. But `parquet/file` has no `noasm`-specific code: every `noasm` 
variant lives in `parquet/internal/bmi`, `parquet/internal/encoding`, 
`parquet/internal/utils` and `parquet/metadata`, which are still tested in both 
passes. The second run repeats the same tests.
   
   ### What changes are included in this PR?
   
   `ci/scripts/test.sh` runs the macOS-only `parquet/file` invocation once, 
with `-tags assert`, after both passes over the other parquet packages. Other 
platforms are unchanged (`parquet/file` stays part of `./...` in both passes 
there).
   
   ### Are these changes tested?
   
   `bash -n` passes. A dry run of the script with `go` stubbed to report darwin 
and print each `go test` command shows the arrow passes unchanged, the other 
parquet packages in both `assert` and `assert,noasm` passes, and `parquet/file` 
once with `assert`. This PR's own macOS jobs exercise it.
   
   ### Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to