zhanchangbao-sanechips commented on code in PR #51340: URL: https://github.com/apache/arrow/pull/51340#discussion_r4386888212
########## cpp/src/arrow/util/dispatch_internal.h: ########## @@ -221,6 +222,16 @@ constexpr DynamicDispatchTarget<Func> BestDispatchTarget( # define ARROW_DISPATCH_TARGET_SVE512(func) #endif +#if defined(ARROW_HAVE_RVV) || defined(ARROW_HAVE_RUNTIME_RVV) +# define ARROW_DISPATCH_TARGET_RVV(func) \ Review Comment: > I don't think that is right, we want per-vector width macros just like for SVE. Thank you for your review,you're right, and I've split RVV into per-vector-width macros to match SVE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
