pitrou commented on code in PR #50749:
URL: https://github.com/apache/arrow/pull/50749#discussion_r4387247166
##########
cpp/src/arrow/status.h:
##########
@@ -148,11 +148,10 @@ class ARROW_EXPORT [[nodiscard]] Status : public
util::EqualityComparable<Status
public:
// Create a success status.
constexpr Status() noexcept : state_(NULLPTR) {}
- ~Status() noexcept {
+
+ ARROW_FORCE_INLINE ~Status() noexcept {
Review Comment:
```suggestion
// GH-47774: force-inline the Status destructor's hot path
// and keep it as lean as possible.
ARROW_FORCE_INLINE ~Status() noexcept {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
