Rich-T-kid commented on PR #11925: URL: https://github.com/apache/arrow-rs/pull/11925#issuecomment-6434782993
>Agreed that the fallback could avoid interleave later, e.g. by merging the dictionaries once and remapping keys directly in the merge loop. If you think it's useful, I can add a dictionary case to merge_kernels.rs in a follow-up so that optimization has a baseline. I'd rather keep this PR focused on the panic. yes this is what I was referring to, we should add a benchmark case where it will trigger this merging. Id recommend including it in this PR as it should be straight forward & minimal. this isn't a very strong opinion though, if you'd like to do it in a follow up PR thats also fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
