hassaanch23 commented on PR #11144: URL: https://github.com/apache/arrow-rs/pull/11144#issuecomment-6445056185
Rebased onto current `main`. The one conflict was with #11262, which added FLBA decoding to `DictionaryDecoder`. I kept its `flba_column_descr`, and the value type is still derived from `validate_utf8`. An FLBA column can't be read into a string dictionary, because a supplied schema asking for that is rejected as incompatible. So the new fixed-width path doesn't need UTF-8 validation. Locally, all of these pass: - `cargo test -p parquet --all-features` - `cargo clippy -p parquet --all-targets --all-features -- -D warnings` - `cargo fmt` The three new tests still fail when run against `main`'s readers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
