zeroshade commented on PR #4955: URL: https://github.com/apache/arrow-adbc/pull/4955#issuecomment-6446432985
Thanks, both P2s addressed in 7be8410 (rebased on main, so the Windows MSYS2 failures from before #4956 should clear): - **Stale watcher:** every `Execute*` now stops and joins the previous execution's cancellation watcher before arming a new one, and releasing a stale reader can no longer disarm the replacement. - **Reader errors:** when `Next()` fails while the context is cancelled, `Err()` keeps the native driver message under the Cancelled/Timeout status. - **Mocking:** removed the package-level `cancelStatement` hook. The tests now use the real SQLite driver. SQLite doesn't implement `StatementCancel`, so they cover the watcher lifecycle, re-execution, and preservation of native errors rather than interrupting an in-flight query. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
