Rich-T-kid commented on code in PR #11878:
URL: https://github.com/apache/arrow-rs/pull/11878#discussion_r4395202324
##########
arrow-buffer/src/buffer/immutable.rs:
##########
@@ -927,6 +929,31 @@ mod tests {
buffer.slice_with_length(2, usize::MAX);
}
+ #[test]
+ #[cfg(feature = "pool")]
+ fn test_into_vec_releases_reservation() {
+ use crate::pool::{MemoryPool, TrackingMemoryPool};
Review Comment:
can we place this import at the test mod levle
##########
arrow-buffer/src/buffer/immutable.rs:
##########
Review Comment:
might be worth explaining that when bool is enabled successful conversions
release the reservation and the returned vec is not tracked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
