zeroshade commented on code in PR #4957: URL: https://github.com/apache/arrow-adbc/pull/4957#discussion_r4402977541
########## go/adbc/drivermgr/doc.go: ########## Review Comment: Removed in 59a56dd. ########## go/adbc/drivermgr/wrapper.go: ########## Review Comment: The drivermgr types can't implement `GetSetOptionsWithContext` directly: they already have `SetOption(key, value)` for `Connection`/`Statement`/`PostInitOptions`, so a `SetOption(ctx, key, value)` would clash (the same conflict `context_adapters.go` notes for `Close`). In 6b8a507 the `As*Context` adapters implement `GetSetOptionsWithContext` instead, forwarding to the wrapped value's `GetSetOptions` (or `PostInitOptions` for `SetOption`). If the wrapped value doesn't support options, getters return `StatusNotFound` and setters `StatusNotImplemented`, per the interface docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
