raulcd commented on code in PR #55294:
URL: https://github.com/apache/arrow/pull/55294#discussion_r4398582828
##########
cpp/src/arrow/compute/row/CMakeLists.txt:
##########
@@ -22,7 +22,7 @@ arrow_install_all_headers("arrow/compute/row")
if(ARROW_BUILD_BENCHMARKS AND ARROW_COMPUTE)
add_arrow_benchmark(grouper_benchmark PREFIX "arrow-compute")
- if(ARROW_BUILD_STATIC)
+ if(ARROW_TEST_LINKAGE STREQUAL "static")
Review Comment:
Following this pattern we probably have to change this one for
`if(ARROW_TEST_LINKAGE STREQUAL "static")`:
https://github.com/apache/arrow/blob/fc390cd3442ba8f2a1db964dee735c6f1234c4e1/cpp/src/arrow/adapters/orc/CMakeLists.txt#L29-L33
##########
cpp/src/parquet/CMakeLists.txt:
##########
@@ -251,6 +251,7 @@ list(APPEND PARQUET_STATIC_LINK_LIBS ${ARROW_XSIMD})
if(PARQUET_REQUIRE_ENCRYPTION)
list(APPEND PARQUET_SHARED_PRIVATE_LINK_LIBS ${ARROW_OPENSSL_LIBS})
+ list(APPEND PARQUET_STATIC_LINK_LIBS ${ARROW_OPENSSL_LIBS})
Review Comment:
Following this pattern we might have to add `list(APPEND
PARQUET_STATIC_LINK_LIBS ${ARROW_OPENTELEMETRY_LIBS}`?
https://github.com/apache/arrow/blob/fc390cd3442ba8f2a1db964dee735c6f1234c4e1/cpp/src/parquet/CMakeLists.txt#L290-L292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
