HuaHuaY commented on code in PR #55306:
URL: https://github.com/apache/arrow/pull/55306#discussion_r4410715557
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1089,8 +1093,6 @@ void ColumnWriterImpl::BuildDataPageV2(int64_t
definition_levels_rle_size,
// Write the page to OutputStream eagerly if there is no dictionary or
// if dictionary encoding has fallen back to PLAIN
if (has_dictionary_ && !fallback_) { // Save pages until end of dictionary
encoding
- PARQUET_ASSIGN_OR_THROW(auto data_copy,
- combined->CopySlice(0, combined->size(),
allocator_));
Review Comment:
I checked the git history and suspect that the author copied
`BuildDataPageV1` and modified it, failing to notice the unused variable.
Meanwhile, `clang-tidy` didn't flag any warning here either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
