vdpoora commented on PR #1429:
URL: https://github.com/apache/arrow-go/pull/1429#issuecomment-6491523269
Thanks for the review. Added a subtest that pins the `Put` itself: it swaps
a recording fake into the encoder's `pool` field (now typed `interface{
Put(any) }`) and checks that `Close` puts that exact encoder back. It fails
with the `pool.Put` removed. I went with a fake over an allocation check
because `sync.Pool` may drop any item, so an alloc-based test would be flaky in
principle and would need a skip under `-race`. This one is deterministic and
runs under `-race` too.
bleep bloop, a clanker wrote this 🤖
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
