ddupg opened a new issue, #893:
URL: https://github.com/apache/arrow-rs-object-store/issues/893

   **Description**
   
   We encountered a process crash while using Lance after configuring an 
invalid S3-compatible endpoint. Investigation traced the panic to 
`object_store`, and we reproduced it directly without Lance.
   
   For example, an endpoint missing its scheme (`bucket.example.invalid`) can 
pass store construction but panic during an operation:
   
   ```text
   panicked at src/aws/credential.rs:461:43:
   request valid: InvalidUri(InvalidUri(InvalidFormat))
   ```
   
   Listing can also panic when constructing the request URI:
   
   ```text
   panicked at src/client/builder.rs:221:61:
   called `Result::unwrap()` on an `Err` value:
   InvalidUriParts(InvalidUri(SchemeMissing))
   ```
   
   Invalid configuration should return an error that callers can handle. These 
failures occur before an HTTP request is sent, so treating request construction 
as infallible is inappropriate.
   
   We propose replacing the relevant `unwrap()` / `expect()` calls with error 
propagation, validating endpoint structure where required, and adding 
regression tests. The same approach should cover affected paths in other 
backends and the shared HTTP client.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to