mapleFU commented on code in PR #55308:
URL: https://github.com/apache/arrow/pull/55308#discussion_r4413642926
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1745,11 +1743,19 @@ class TypedColumnWriterImpl : public ColumnWriterImpl,
*out_spaced_values_to_write = batch_size;
*null_count = 0;
} else {
+ // Accumulate in locals: accumulating through the int64_t* out-params
makes
+ // every iteration a memory read-modify-write, which blocks
vectorization.
Review Comment:
Done, but another issue is, the `bits_buffer_` is updated internal, so this
function cannot marked as const. Should I also mark `bits_buffer_` and
`level_info_` as argument to make this static function? Or just leave them
here? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
