zeroshade commented on code in PR #1433:
URL: https://github.com/apache/arrow-go/pull/1433#discussion_r4414395263
##########
arrow/flight/flightsql/client.go:
##########
@@ -312,9 +316,12 @@ func (c *Client) executeIngest(ctx context.Context, rdr
array.RecordReader, reqO
return 0, err
}
- if err = stream.CloseSend(); err != nil {
+ if err = wr.Close(); err != nil && !errors.Is(err, io.EOF) {
return 0, err
}
+ wr = nil
+
+ _ = stream.CloseSend()
Review Comment:
actually, never mind. we need it to run before the `Recv` call so it can't
be a defer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
