etseidl commented on code in PR #11957:
URL: https://github.com/apache/arrow-rs/pull/11957#discussion_r4415191760
##########
arrow-array/src/array/fixed_size_binary_array.rs:
##########
@@ -398,125 +398,6 @@ impl FixedSizeBinaryArray {
}
}
- /// Create an array from an iterable argument of sparse byte slices.
- /// Sparsity means that items returned by the iterator are optional, i.e
input argument can
- /// contain `None` items.
- ///
- /// # Examples
- ///
- /// ```
- /// use arrow_array::FixedSizeBinaryArray;
- /// let input_arg = vec![
- /// None,
- /// Some(vec![7, 8]),
- /// Some(vec![9, 10]),
- /// None,
- /// Some(vec![13, 14]),
- /// None,
- /// ];
- /// let array =
FixedSizeBinaryArray::try_from_sparse_iter(input_arg.into_iter()).unwrap();
- /// ```
- ///
- /// # Errors
- ///
- /// Returns error if argument has length zero, or sizes of nested slices
don't match.
- #[deprecated(
- since = "28.0.0",
- note = "This function will fail if the iterator produces only None
values; prefer `try_from_sparse_iter_with_size`"
- )]
- pub fn try_from_sparse_iter<T, U>(mut iter: T) -> Result<Self, ArrowError>
- where
- T: Iterator<Item = Option<U>>,
- U: AsRef<[u8]>,
- {
- let mut len = 0;
- let mut value_size = None;
- let mut byte = 0;
-
- let iter_size_hint = iter.size_hint().0;
- let mut null_buf = MutableBuffer::new(bit_util::ceil(iter_size_hint,
8));
- let mut buffer = MutableBuffer::new(0);
Review Comment:
Another bot nit: this fn uses fallible methods to grow the buffer, and
returns `MemoryError` if they fail. The preferred
`try_from_sparse_iter_with_size` instead uses infallible
`MutableBuffer::new(capacity)`, which may panic. This changes the behavior of
the `TryFrom` impl. Not sure how big a deal that is.
##########
arrow-ipc/src/gen/Message.rs:
##########
@@ -27,24 +27,6 @@ use std::{cmp::Ordering, mem};
// @generated
-#[deprecated(
- since = "2.0.0",
- note = "Use associated constants instead. This will no longer be generated
in 2021."
-)]
-pub const ENUM_MIN_COMPRESSION_TYPE: i8 = 0;
Review Comment:
My bot points out it seems these are produced by flatc, so if these files
are regenerated the deprecated constants will reappear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
