lidavidm commented on code in PR #4924:
URL: https://github.com/apache/arrow-adbc/pull/4924#discussion_r4410914781
##########
go/driver/internal/driverbase/error.go:
##########
@@ -35,3 +36,10 @@ func (helper *ErrorHelper) Errorf(code adbc.Status, message
string, format ...in
Msg: fmt.Sprintf("[%s] %s", helper.DriverName, msg),
}
}
+
+// isNotImplemented reports whether err is an ADBC error with status
+// NotImplemented, which is how the *ImplBase types reject unknown options.
+func isNotImplemented(err error) bool {
+ var adbcErr adbc.Error
+ return errors.As(err, &adbcErr) && adbcErr.Code ==
adbc.StatusNotImplemented
Review Comment:
this should use AsType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
