adriangb commented on code in PR #11609:
URL: https://github.com/apache/arrow-rs/pull/11609#discussion_r4420720808
##########
parquet/src/arrow/push_decoder/reader_builder/data.rs:
##########
@@ -198,40 +191,47 @@ impl<'a> DataRequestBuilder<'a> {
column_chunks,
} = self;
- let row_group_meta_data = parquet_metadata.row_group(row_group_idx);
+ let row_group = parquet_metadata.row_group(row_group_idx);
// If no previously read column chunks are provided, create a new
location to hold them
- let column_chunks =
- column_chunks.unwrap_or_else(|| vec![None;
row_group_meta_data.columns().len()]);
-
- let page_index = if parquet_metadata
- .page_index()
- .is_some_and(|pi| pi.has_offset_indexes())
Review Comment:
Nice to see two pieces of identical code collapse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
