andygrove commented on PR #1418: URL: https://github.com/apache/arrow-java/pull/1418#issuecomment-6544963022
Note for reviewers: this overlaps with #1247, which fixes the `setBigEndian(int, byte[])` and `setBigEndianSafe(int, long, ArrowBuf, int)` paths. This PR additionally covers `setSafe(int, long, ArrowBuf, int)` (no length check at all today) and the zero-length sign-extension read in the `ArrowBuf` variants. I've left a comment on #1247 suggesting those be folded in there. If that happens I'll close this one; otherwise I'll rebase this on top of #1247 once it merges so the remaining fixes land as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
