Jefffrey commented on code in PR #11912:
URL: https://github.com/apache/arrow-rs/pull/11912#discussion_r4434692114
##########
arrow-array/src/array/fixed_size_binary_array.rs:
##########
@@ -540,7 +544,8 @@ impl FixedSizeBinaryArray {
///
/// # Errors
///
- /// Returns error if argument has length zero, or sizes of nested slices
don't match.
+ /// Returns an error if `value_length` is negative, a byte slice has a
different length,
+ /// size arithmetic overflows, or a buffer allocation fails.
Review Comment:
probably can make this dot point list
```rust
/// - `value_length is negative`
/// - Byte slice has different length
/// - Size arithmetic overflows
/// - Buffer allocation fails
```
(same for the rest below where they get a bit too long like this)
##########
arrow-array/src/array/fixed_size_binary_array.rs:
##########
Review Comment:
yeah this is pretty old; i think we should actually leave it untouched and
then remove it in next major release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
