jonasdedden commented on PR #51611: URL: https://github.com/apache/arrow/pull/51611#issuecomment-6556546999
@zanmato1984 Agreed, I think the stricter semantics are better: - `equal` itself raises for a null `float64` compared with the `int64` 2**53+1. - The masking only existed so that null scalar lists and arrays of null lists agree, which they also do when both raise. Done in 70e12b2: a `DispatchBest` override picks the query type with the same `ComparableTypes`, and the executor safely casts the queries before the kernel runs. `MaskQueries` and the retry are gone, and only the tests asserting the old behavior changed. I kept two things as they are: - Child values of null lists and of list view gaps are still not cast. They aren't part of the input's logical values, and casting the list type would cast all of them. - All-null queries still only need validity, as you asked earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
