EmilyMatt commented on code in PR #11982:
URL: https://github.com/apache/arrow-rs/pull/11982#discussion_r4435483853
##########
parquet/src/arrow/arrow_writer/byte_array.rs:
##########
@@ -993,7 +1130,7 @@ fn count_within_budget_views(
// value by `max_value_len`. Skips the walk for the common small-value
// case (what view arrays are built for, and where there is nothing to
// bound).
- let per_value = max_value_len + std::mem::size_of::<u32>();
Review Comment:
No problem, though I think this moves the project away from having a no_std
option, but maybe that's not a goal right now
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -2520,6 +2520,86 @@ mod tests {
writer.into_inner().unwrap()
}
+ #[test]
+ fn arrow_writer_string_dictionary_reused_across_batches() {
+ use arrow::compute::{cast, concat};
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
