EaswarKilari opened a new pull request, #12021: URL: https://github.com/apache/arrow-rs/pull/12021
# Which issue does this PR close? - Closes #11597 # Rationale for this change The rustdoc of `arrow_arith::aggregate::min` and `max` says NaN values are greater than any other non-null value, but the kernels compare floats with IEEE 754 totalOrder (as documented on `ArrowNativeTypeOp`). Under totalOrder a negative NaN sorts below every other value, so `min` returns it and `max` never does. # What changes are included in this PR? Doc comment update only: both functions now describe totalOrder and link to `f64::total_cmp`. No code changes. # Are these changes tested? No behavior change. The documented behavior is already covered by `test_primitive_min_max_float_negative_nan`. # Are there any significant user-facing changes? No. AI usage: an AI assistant helped locate the relevant code and draft the doc wording. I reviewed the change myself and confirmed it against the `total_cmp`-based comparison in `ArrowNativeTypeOp` and the existing tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
