kaifkhan93544 commented on issue #1412: URL: https://github.com/apache/arrow-java/issues/1412#issuecomment-6578261704
Hi @mykolapavlov-dremio I reviewed this issue along with the ongoing draft in PR #1411. Ensuring PreparedStatement.executeBatch() is fully JDBC-compliant by executing each parameter set and draining `PutResult` streams without allocator leaks is a valuable fix. The expected approach entails: 1. Iterating through all queued parameter sets in `ArrowFlightSqlPreparedStatement` / batch executor. 2. Collecting individual update counts into `int[]` matching the batch size. 3. Guaranteeing that Flight SQL streams and allocated vectors are cleanly drained and closed in `finally` blocks. 4. Catching intermediate failures and throwing a `BatchUpdateException` containing partial update counts per JDBC spec. @mykolapavlov-dremio, are you actively working on finalizing PR #1411, or would you welcome assistance / a rebased PR to help get this across the finish line with complete unit tests? Happy to collaborate! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
