nirandaperera commented on a change in pull request #10410: URL: https://github.com/apache/arrow/pull/10410#discussion_r643117391
########## File path: cpp/src/arrow/compute/kernels/scalar_if_else_test.cc ########## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <arrow/array.h> +#include <arrow/compute/api_scalar.h> +#include <arrow/compute/kernels/test_util.h> +#include <arrow/testing/gtest_util.h> +#include <gtest/gtest.h> + +namespace arrow { +namespace compute { + +void CheckIfElseOutput(const Datum& cond, const Datum& left, const Datum& right, + const Datum& expected) { + ASSERT_OK_AND_ASSIGN(Datum datum_out, IfElse(cond, left, right)); + if (datum_out.is_array()) { + std::shared_ptr<Array> result = datum_out.make_array(); + ASSERT_OK(result->ValidateFull()); + std::shared_ptr<Array> expected_ = expected.make_array(); + AssertArraysEqual(*expected_, *result, /*verbose=*/true); + } else { // expecting scalar + const std::shared_ptr<Scalar>& result = datum_out.scalar(); + const std::shared_ptr<Scalar>& expected_ = expected.scalar(); + AssertScalarsEqual(*expected_, *result, /*verbose=*/true); + } +} + +class TestIfElseKernel : public ::testing::Test {}; + +template <typename Type> +class TestIfElsePrimitive : public ::testing::Test {}; + +using PrimitiveTypes = ::testing::Types<Int8Type, UInt8Type, Int16Type, UInt16Type, + Int32Type, UInt32Type, Int64Type, UInt64Type, + FloatType, DoubleType, Date32Type, Date64Type>; + +TYPED_TEST_SUITE(TestIfElsePrimitive, PrimitiveTypes); + +TYPED_TEST(TestIfElsePrimitive, IfElseFixedSizeRand) { + using ArrayType = typename TypeTraits<TypeParam>::ArrayType; + auto type = TypeTraits<TypeParam>::type_singleton(); + + random::RandomArrayGenerator rand(/*seed=*/0); + int64_t len = 1000; + auto cond = std::static_pointer_cast<BooleanArray>( + rand.ArrayOf(boolean(), len, /*null_probability=*/0.01)); + auto left = std::static_pointer_cast<ArrayType>( + rand.ArrayOf(type, len, /*null_probability=*/0.01)); + auto right = std::static_pointer_cast<ArrayType>( + rand.ArrayOf(type, len, /*null_probability=*/0.01)); + + typename TypeTraits<TypeParam>::BuilderType builder; + + for (int64_t i = 0; i < len; ++i) { + if (!cond->IsValid(i) || (cond->Value(i) && !left->IsValid(i)) || + (!cond->Value(i) && !right->IsValid(i))) { + ASSERT_OK(builder.AppendNull()); + continue; + } + + if (cond->Value(i)) { + ASSERT_OK(builder.Append(left->Value(i))); + } else { + ASSERT_OK(builder.Append(right->Value(i))); + } + } + ASSERT_OK_AND_ASSIGN(auto expected_data, builder.Finish()); + + CheckIfElseOutput(cond, left, right, expected_data); +} + +template <typename Type> +struct DatumWrapper { + using CType = typename TypeTraits<Type>::CType; + using ArrayType = typename TypeTraits<Type>::ArrayType; + using ScalarType = typename TypeTraits<Type>::ScalarType; + + util::Variant<std::shared_ptr<ScalarType>, std::shared_ptr<ArrayType>> datum; + bool is_scalar; + + explicit DatumWrapper(const Datum& datum_) : is_scalar(datum_.is_scalar()) { + if (is_scalar) { + datum = std::move(std::static_pointer_cast<ScalarType>(datum_.scalar())); + } else { + datum = std::move(std::static_pointer_cast<ArrayType>(datum_.make_array())); + } + } + + bool IsValid(int64_t i) const { + return is_scalar ? util::get<std::shared_ptr<ScalarType>>(datum)->is_valid + : util::get<std::shared_ptr<ArrayType>>(datum)->IsValid(i); + } + + CType Value(int64_t i) const { + return is_scalar ? util::get<std::shared_ptr<ScalarType>>(datum)->value + : util::get<std::shared_ptr<ArrayType>>(datum)->Value(i); + } +}; + +template <typename Type> +void GenerateExpected(const Datum& cond, const Datum& left, const Datum& right, Review comment: `GenerateExpected` generate both `Scalar` and `Array` outputs (Array part is L144 onward) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
