amoeba commented on code in PR #55321:
URL: https://github.com/apache/arrow/pull/55321#discussion_r4447823266
##########
.github/workflows/package_odbc.yml:
##########
@@ -179,3 +223,231 @@ jobs:
gh release upload $env:GITHUB_REF_NAME `
--clobber `
Apache-Arrow-Flight-SQL-ODBC-*-win64.msi
+
+ # The dylib must be signed (outside of CI) before it goes into the PKG, so
+ # the unsigned universal dylib and the ARM64 base PKG are uploaded first and
+ # the universal PKG is assembled in odbc-macos-upload-pkg after the signed
+ # universal dylib is available on the release.
+ odbc-macos-upload-dylib:
+ name: ODBC macOS Upload Unsigned ${{ matrix.architecture }} DYLIB
+ runs-on: macos-${{ matrix.macos-version }}
+ if: github.event_name == 'push'
+ timeout-minutes: 120
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - { architecture: AMD64, macos-version: "26-intel" }
+ - { architecture: ARM64, macos-version: "26" }
+ env:
+ ARROW_BUILD_TESTS: OFF
+ ARROW_BUILD_TYPE: release
+ ARROW_DEPENDENCY_SOURCE: BUNDLED
+ ARROW_DEPENDENCY_USE_SHARED: OFF
+ ARROW_FLIGHT_SQL_ODBC: ON
+ ARROW_FLIGHT_SQL_ODBC_INSTALLER: ON
+ ARROW_HOME: /tmp/local
+ ARROW_MIMALLOC: OFF
Review Comment:
```suggestion
ARROW_MIMALLOC: OFF
MACOSX_DEPLOYMENT_TARGET: "14.0"
```
Did we decide on a minimum macOS version to target? If I understand
correctly, as this PR stands, the macOS installer won't run on macOS versions
older than macOS 26 (the runner's OS).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
