bhaskargurram-ai opened a new pull request, #12040: URL: https://github.com/apache/arrow-rs/pull/12040
# Which issue does this PR close? - Follow-up to #11741, as discussed in #11549. # Rationale for this change #11741 enabled hashbrown's `inline-more` feature. Cargo unifies features, so this turns it on for every crate in a build that uses the same hashbrown version, including ones that set `default-features = false` to avoid it (raised by @HippoBaro). The fix for the #11741 regression was `#[inline]` on `Interner::intern`, which stays. # What changes are included in this PR? Removes `inline-more` from the `hashbrown` dependency in `parquet/Cargo.toml` and updates the `Interner::intern` comment. # Are these changes tested? Existing tests. I compared callgrind instruction counts of the `arrow_writer` benches on main with and without the feature: the dictionary and REE benches that #11741 fixed are unchanged (within ±1.7%), and `primitive`, `primitive_non_null` and `primitive_dictionary` are 3-6% higher, all in hashbrown's `reserve_rehash`. A benchmark bot run would confirm the wall-clock effect. # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
